Assurance Chioma Ikogwe
@Aik-202All comments
- @fkrunicSubmitted about 1 year ago@Aik-202Posted about 1 year ago
Wow! Nice work, I loved the feature of scanning the card you added, but:
- There's an issue with the "Card number"" expiration year" checks, even with the correct input, it keeps showing the error message.
- After every 4 numbers for the card number input field you can add an extra line of space.
- You can also restrict card name to letters only, card number, expiration date, and CVC to numbers only.
- You can use the
maxlength
attribute in you input fields to restrict the length of the input field.. for example CVC input field will have a maxlength` of 3.
These are my suggestions, great work once again!
Marked as helpful0 - @mukwende2000Submitted about 2 years ago
Hello everyone, I need your help, I am really struggling with responsive design, I struggled with this one too, how do I go about it, I have read about fluid layouts, fluid images, and even media queries but it just doesn't seem to help because I'm having trouble implementing them. I will appreciate any feedback.
@Aik-202Posted about 2 years agoHi Mukwende, you did okay. I have some suggestions though.
- Change the
div
withclass container
tomain
, as every html page must have one main tag. - Remove one
h1
heading from your page. I suggest you remove this one with<h1 class="center">Get early access today</h1>
as they ought to be just one main heading. you can useh3
and style it the way you want. - You are right, the responsiveness is not quite there. I use
media queries
for responsiveness. You used@media screen and (min-width: 768px)
. What this means is that the code below it is for screens with size 768px and above, that is for ipads and desktop. That's by the way side. Although, the responsiveness is not the problem, there's atext overflow
from :<h1 class="center">All your files in one secure location, accessible anywhere.</h1>
And<p>It only takes a minute to sign up and our free starter tier is extremely generous. If you have any questions, our support team would be happy to help you.
I suggest you adjust that. - Then set
margin:0
for the body, so that there's no visible spacing around the page.
Hope this helps, do well to update your solution when you make these changes.
Marked as helpful1 - Change the
- @baskarancs15Submitted about 2 years ago
MY FIRST SUBMIT IN FE MENTOR. ALL FEEDBACK ARE WELCOME !CHEERS
@Aik-202Posted about 2 years agoHi Baskaran, Nice work!. I have some suggestions though :
- Change the
div
withclass container
tomain
as every html page must have a main tag. - For the Mobile mode(
@media(max-width:600px)
), there's an issue, there's too much space at the top. Then I noticed fir the desktop you set the margin top and bottom to 20em withmargin-top: 20em auto
. Reduce the margin-top for the mobile mode ... It's too much. - I noticed you were actually using the margins above to center the container?. If that's right, it's better to set
justify-content: center
andalign-items: center
in your css. This will center your container. - Also, try and adjust the
max-width
of your container for mobile mode, they seem too big.
Hope this helps, please update your solution when you make the changes.
Marked as helpful0 - Change the
- @DavidQA71Submitted about 2 years ago
Hello everyone! this is my third challenge. I had some difficulties to finish it but finally I did it. Surely the code can be improved so any advice is welcome. Happy code!
@Aik-202Posted about 2 years agoHi David, Nice work, you did justice to this. I have some suggestions though:
- Turn the
div
withclass container
tomain
tag as every html page must have amain
tag as it tells screen readers where the page starts from. - Then in each of your
section
... Turn the firstp
tags withclass p1
to h2 -h6 headings. As sections must begin with h2-h6 headings. That should solve some of your accessibility problems. Nice work once again. Hope this helps, you can update your solution once you've made these changes.
Marked as helpful0 - Turn the
- @AdrianmbuguaSubmitted about 2 years ago
Hi , Im not able to resize my fontawsome icons, any suggestions welcome
@Aik-202Posted about 2 years agoHi Adrian, nice work! To answer your question the way to resize font awesome icons is to use
font size
. Using fa-2x in your class simply gives the icon a font size of 2em. this link will tell you more about sizing of font awesome icons . Also, for your accessibility issues, change the div with class main to themain
tag, as every page must have onemain
tag. Try also to center the button, it looks a little bit off in the mobile view.Hope this helps.
Marked as helpful0 - @lichtleSubmitted about 2 years ago
This was my first attempt using CSS flex and I had some issues making the justify-content property work, I feel like the coding is all wrong. I'd appreciate any tips on accessibility, CSS flex and on how to make my code cleaner!
@Aik-202Posted about 2 years agoHi, Leticia... Nice work, you did amazing... I see that you used an entirely different color theme, it's beautiful. I have some suggestions though...
- I'll like to ask, why did you use div for every content??. You can use the different levels of headings, the p tag, pre tag, for your content and style them as you like. I feel like the purpose of
div
is for grouping contents. So I'll advise you change the div with class name to anh1
tag. That will solve ya accessibility issues. - I also checked ya code, I don't see anything wrong with the way you wrote it tho. One thing to note is that if you are using the
justify-content: center;
to center a div, you also need to includealign-items: center
for it to work.
Nice work once again. Hope this helps.
Marked as helpful1 - I'll like to ask, why did you use div for every content??. You can use the different levels of headings, the p tag, pre tag, for your content and style them as you like. I feel like the purpose of
- @H7iooSubmitted about 2 years ago
Hi there 👋😀, any suggestions to make the code better?
@Aik-202Posted about 2 years agoHi, Omar! Wow! Nice work! I love the idea that you can see the choices of the house toggle until one is finally picked. It's really nice!!!. But for the mobile view it's not quite there... Some contents are overlapping and the score box is too big... And try changing the
section
tag tomain
tag. This is really nice. Well done!!!Marked as helpful0 - @Khanza2Submitted about 2 years ago
Any feedback would be appreciated!
@Aik-202Posted about 2 years agoHi, Khan... Nice work!!!!. I have some suggestions though :
-
Try changing the
section
tag with class maincontainer tomain
tag, as every html page must have a main tag, as it helps screen readers know where the main content of the page is located. -
Remove the the href attributes that have no value from the anchor tags, that should sole some of your html issues.
-
For the mobile mode, it's not exactly pixel perfect, you can also reduce the size of the images as they appear too big. You can also reduce the font-sizes of the headings, they also appear too big.
Hope this helps.
Marked as helpful0 -
- @ContrerasdevSubmitted about 2 years ago
Using flexbox :wcontreras My first challenge From Nicaragua.
@Aik-202Posted about 2 years agoHi Walter, Nice work!!!!. I have some suggestions though
- Change the
div
tag with class container tomain
, as there must be amain
tag in your html... - You can change the
button
tag to adiv
and give it aria role "button", this will help fix the html issue. i.e<div role = "button"></div>
- Instead of using
h1
tag for the striked price you can use thesup
tag , it's used for superscripted text in html... and it can be embedded in the firsth1
tag with class precio i.e<h1 class="precio" > $149.99 <sup>149.98</sup> </h1>
.. by doing this you will reduce the spacing between the two digits..
Marked as helpful0 - Change the
- @MIHI-botSubmitted about 2 years ago
This E-commerce Product page is my first project and I really enjoyed creating this project, however, it is still incomplete and will be completed after your feedback.
@Aik-202Posted about 2 years agoHi Mihir, this is wonderful! Nice work! I have some suggestions tho.
-
Make sure to always put an alt text for all your images, I think that should fix most of your html and acessibility issues
-
For the ones that say you should add img src, I think the problem as to do with the way you wrote the src for the images. It ought to have been
./images/img.jg
as the images is in another folder. -
Use the
main
tag for the div with class modal as that is where your main content starts from. -
Instead of using
strike
tag, use this in your css :text-decoration: line-through
-
I also noticed that once I change the number of shoes I'm ordering, it remains unchanged in my cart.
-
Instead of using the
button
tag for your plus and minus icons, try using thediv
tag, and assigning the aria role button... i.e<div role = "button"> </div>
Hope this helps.
0 -
- @melco10Submitted about 2 years ago
Which areas of your code are you unsure of?
- I'm unsure of how i build my javascript for me it can be better code. but this code work for me and also I'm struggling on my logic of how I'm gonna apply a submit rate(1-5) but overall working. I wish I'll add some warning state when there's no number input but I don't really know where to start and my javasscript are only limited. but overall feel so good in the end.
Feel Free to leave suggestion!.
@Aik-202Posted about 2 years agoHi Co, Nice work!!!!. But I have some suggestions. For the JavaScript,
- From the cards, it's already obviously that the user is only suppose to choose from 1 to 5, so there's no need testing for that. Rather it should be something like this.
if (!rateNum) //that is rateNum is undefined { //error message } else { //submit rating }
This way you get to provide a check for when the user does not enter any input.
For the html
-
Try changing that h2 heading to h1, it will solve ya accessibility issue as there must be an h1 heading in your html...
-
Add alt to all your images, you can see why here
-
I feel like the link google.com wrapped around the star image is not necessary. What were you trying to achieve with that?🤔🤔🤔
-
You can remove the link embedding the submit button, as it's not serving any purpose there.
Hope, this helps.
Marked as helpful0 - @AtulKumar0001Submitted about 2 years ago
How can I make it better? I would appreciate the tips.
@Aik-202Posted about 2 years agoHi Atul, this is pixel perfect!!!! 😍😍😍. But I have some suggestions that can help you with your accessibility issues.
-
You can change that div with class big container to main, as your code must have one main tag or you can add this to big container
role = 'main'
. Then the big container will be treated as main -
Change the h2 tag to h1, you can give it any font size in your css.
-
Attach
aria roles
to each of your divs. I think the aria role to be used for the div with class container is group i.erole = 'group'
. Click on this link to know more about aria roles
Hope this helps.
0 -