The code allows users to operate on numbers at a go. But there's a problem , when the user enters something like "5+5" then presses the minus key. The code doesn't seem to work unless the sign pressed is the same as the one used as the operation. Is there a way I can sort that out.
How would you rate this code out of 10?
The code is not designed to be responsive yet the card on mobile seems adequate (not sure about this)
Are there any obvious mistakes here?
Thanks:)
Good work Richard!
I have one suggestion, "HTML & CSS foundations" is clickable, and clickable items should be either a button or an anchor depending on the action :)
Building this project significantly improved my coding skills by immersing me in the practical application of HTML and CSS.
Any Suggestion ? Or Feedback ?
Thank You.
Good work!
Here are a few suggestions:
-Try to use classes for styling instead of directly styling elements.
-Implement a CSS reset.
-Avoid using Px for font-size
-Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.
Hi, would like to get your opinion on font-sizes.
body { font-size: 0.8rem; } @media (min-width: 40rem) { body { font-size: 1rem; } } .child { font-size: 1rem; }
Thanks! Aleš
As @techyjc said, you need to define :root instead of repeating the size each time. but you are right about rem, it is not recommended to use px
Any tips and suggestions are welcome :)
Good work!
Here are a few suggestions:
-You don't need an extra <div>, you can wrap the whole content with one <div>
-Implement a CSS reset.
-Use em or rem for font-size instead of px
-Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.
Great work! I assume this should be <a> instead of <h2> because it's clickable.
Also, consider using rem or em instead of px for font-size.
Thanks for checking this out any input is much appreciated!
You can use <s> for the old price and also it's better to add some visually hidden text for the old price and the current price for screenreaders users
I couldn't break the edge down a little, like on the model. Any help please?
In this solution what I found difficult was how to make it better using less code and create the symantic html that is most simple and basic. I know that this should be an easy challenge so I wanted to make it less code and simpler. I am unsure of the width and the height of the code.
I believe I did a better job this time around. if there is any critiques that need to be made as far as detail I would like to improve. thank you for all the feedback.
Good start! Here are a few suggestions:
-Consider using 'justify-content: center;' to center the card on the page.
-Try to use classes for styling instead of directly styling elements.
-Implement a CSS reset.
-Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.
I really struggled to do an overlay of purple hue over the image. I ended up using a div with a background of the image url, but this omits any alt text which comes with an img element. I couldn't get a ::before or ::after pseudo element to work with an img element. Are there some rules that I don't know about? Does anyone have any good articles/tutorials on doing overlays over an image?
Thanks!
Actually, it's enough to have a background-color and then use mix-blend-mode: multiply; and then control the opacity
I have some suggestions based on advice I received from other developers:
-Use classes for elements like h2, p, etc. Consider applying different styles across the entire website if needed.
-Implement a CSS reset.
-Avoid using pixels for font-size.
-Consider using 'display: flex', 'justify-content', and 'align-items: center' for the body to center the box.
#Day 15 of frontend training For this piece, it took me 2 days to create. On the first day, I practiced doing it myself using the knowledge I gained from the past 10 days. After encountering a problem that I didn't understand, I went to study on YouTube. and solve problems until getting the finished product
Great job on your work! I have a few notes to share. I'm also in the process of learning and addressing past challenges to reach best practices. Here's some feedback I received that might be helpful to you:
-It's recommended to have only one h1 per page. For this task, consider using h2 headings for 'Sedans,' 'SUVs,' and 'Luxury.'
-Instead of using buttons, consider using anchors as these will navigate to other pages.
-Incorporating landmarks such as 'Main' and 'Footer' would improve the page's accessibility and structure.
