Skip to content
OverviewSolutions
15
Comments
5
Adan Saavedra
@AdanSaavedra

All comments

  • Adan Saavedra•250
    @AdanSaavedraPosted over 2 years ago

    Well done bro, but i saw you forgot to put the hover state elements, you can learn more about it here. Also you have problems with the accessibility, I took a look to your code and you should use h1 tag first instead of h2, following the semantics rules. I hope this suggestions helps you.😁👍🏾

    Marked as helpful
    0
  • Paul THEUREAU•120
    @Paul21777Submitted over 2 years ago

    Hello !

    I made this project with grid to try building a layout on my own.

    I will try to make it responsive when I will learn how to do it.

    The color in front of the image is not accurate, I use a technic that might not be the one needed, if someone have a solution for it, I will be grateful !

    Any comment is very welcome.

    Thanks you

    First layout using CSS grid

    1
    Adan Saavedra•250
    @AdanSaavedraPosted over 2 years ago

    Well done bro, but i saw you have problems with the accessibility, Document should have one main landmark, this issue I'd due to the inability to detect the main content within your document. You can resolve thus by using the semantic main tags which will indicate that any tags enclosed with is the main content. Read more on semantic tags here

    0
  • Josh•100
    @j-likes-spicySubmitted over 2 years ago

    Good Evening Everyone,

    This is my solution for the QR Code Component. I've invested several hours into learning web and application development over the past year or so, so I've decided to complete all FEM challenges possible ranging from easiest to most difficult. This project was pretty simple overall; I was able to achieve this look with minimal classes. I set a root font size on the body of 16px and converted all units to REMs. If you have any tips or suggestions, please let me know. I love to learn and am always open to any form of feedback.

    QR Code Component

    2
    Adan Saavedra•250
    @AdanSaavedraPosted over 2 years ago

    That's pretty well done bro, one suggestion, "0 1rem 1rem 1rem" in the margin property of the paragraph could fit better instead of the one you already put.🔥👍🏾

    Marked as helpful
    0
  • LilMus•160
    @LilMusSubmitted over 2 years ago

    I tried to practice flexbox for this challenge and to make it responsive eventhough it is not needed. I still feel like my css file could be lighter with less lines and less sections what do you think about it ?

    QR Code component using flexbox

    1
    Adan Saavedra•250
    @AdanSaavedraPosted over 2 years ago

    Well done bro, just a suggestion, I think if you put to the first text the font-size property of x-large, it could be better🔥👍🏾

    1
  • Adan Saavedra•250
    @AdanSaavedraPosted over 2 years ago

    Well done bro, just a suggestion, you can add "transition" property to the image overlay to get smoother. 🔥👍🏾

    Marked as helpful
    0