P
Fatih ŞAHİNBAŞ• 470
@fsahinbas
Submitted
P
AdamullaOsas
@AdamullaOsas
All comments
- PAdamullaOsas• 390
@AdamullaOsas
Posted
It's very similar to the design, page looks good. Functionality also works very well. One thing I can give as an advice is that you should break down your 500lines of code into smaller components, so it's more readable and easier to understand.
0 - Mesroua Djamel• 330
@MesrouaDjamel
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
Your page looks mostly good, but there are a few changes to make:
- Hovering over navbar links should show orange strip below the text
- You should not be able to put negative values as a number of item
- Items should be added to cart after clicking button, not after putting number of items
But Im really big fan of your image slider and its smoothness
0 - PFatih ŞAHİNBAŞ• 470
@fsahinbas
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
Your desktop view looks great! The use of CSS Grid is impressive. However, the mobile view could use some improvements. Right now, below 480px, the page isn't scrollable, making it difficult to access the navbar. You might want to add something like
min-height: 100vhto the container, so the page remains scrollable if content overflows.Also, ensure responsiveness across all devices, not just the ones specified in the task. For example, the layout becomes unreadable below 1000px, with part of the navigation cut off. Try to avoid using fixed widths like
width: 1110px; instead, consider using margins, paddings, and gaps to create space. You could also usemax-width: 1110pxif necessary. This will make your page more adaptable to smaller screens.Marked as helpful
0 - Faris• 100
@FarisKarim
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
You can try to size it better to look more like in a design, but overall frontend looks good. Your errors messages works flawlessly. But there is no alert poping up or email validation
0 - TCO932• 220
@TCO932
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
very good job, looks almost the same as the design while keeping the functionality
0 - AZZAM-K• 270
@AZZAM-K
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
App functionality looks good, but you need to pay more attention to sizing, spacing and colors provided in style guide to improve readability
0 - PAbdessalam Barka• 430
@barka-dev
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
Your app looks really good, honestly nothing much more to say. One little thing I can mension is when you select an answer it applies this purple border and fills with purple this "square" with A B C or D. When you hover over selected answer this square has applied onhover effect and changes color.
Marked as helpful
0 What are you most proud of, and what would you do differently next time?
I finished the first intermediate challenge.
What challenges did you encounter, and how did you overcome them?
The styling of the input type range. I found a cool website that given some parameters returned all the stlyle needed for the range.
What specific areas of your project would you like help with?
There is some refactory especially in the javasript file that should have been done but I was anxious to post my solution and to continue my learning journey. Anyway I don't know if the proposed solution is a good one for generating a random password. Except for some lexical awkardness(coming from a python background there is some way I should walk before mastering the javascript way and syntax) maybe there is some other clever method to generate a random password. Any comments on anything will be greatly appreciated. Thank you very much!
PAdamullaOsas• 390@AdamullaOsas
Posted
In my opinion you should work on some sizing and displaying elements just to improve the looks, but functionality is mostly good despite of the copy button that does not copy your password... There are a lot of "password generators" on youtube and the web so you definitely can go and look up some other solutions. I found how to style my input range element, so it looks so much better than I've expected
0What are you most proud of, and what would you do differently next time?
Another solution that wasn't easy, JS was used a lot in this solution because I had a lot of buttons, so I had to use a lot of array methods, I got a little lost but I managed to find other solutions and documentation.
What challenges did you encounter, and how did you overcome them?
I found it difficult to deal with a lot of data at the same time, with a lot of buttons, I had to develop a lot of logic, GPT chat helped me with some things unfortunately.
What specific areas of your project would you like help with?
Any feedback is welcome!
PAdamullaOsas• 390@AdamullaOsas
Posted
Overall project looks really good, but when I enter bill and choose tip% and later I put number of people it does not display calculated value. Also somewhere between 810px and 800px screen width your styling is aligned to the left. The last thing is that you can't add a background-image to the input field, you can also thing about wrapping whole thing (bill, tip% and number of people) in one <form> tag instead of two smaller. You can also thing about changing input type=text instead of type=number.
0- Sonja Krafft• 310
@sonmikrafft
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
I admire really minimalistic HTML code, little bit of sizing to fix, but overall it looks and works excellent
0 - Kapkrazy• 190
@Kapkrazy
Submitted
What are you most proud of, and what would you do differently next time?
I need to get my javascript game up
What challenges did you encounter, and how did you overcome them?
Validation was a bit of a struggle.
PAdamullaOsas• 390@AdamullaOsas
Posted
your page definitely needs some css repair, you need to implement more sizing to elements. Your js code looks good, but in my opinion it looks better when it is in separate file, I noticed that you haven't added
novalidatein your form, so your validation that you've implemented is not working0 - Dhia• 710
@Dhia-18
Submitted
PAdamullaOsas• 390@AdamullaOsas
Posted
You need to work on sizing elements a little bit, because I can see it is your main problem to fix. Try to add some margins and paddings and maybe thing about some max-width or max-height. Your share component on desktop is well done and functional, but on the mobile this changing height is uncomfortable to use.
Marked as helpful
1
