Skip to content
OverviewSolutions
5
Comments
3
Antonio Santiago
@Ablueremote

All comments

  • Antonio Santiago•90
    @AblueremotePosted about 2 years ago

    Well done! Congratulations on completing this project.

    I am also a beginner but I have some help for the HTML issues your report is giving you.

    The main role is unnecessary for element main. [<main class=main role=main>] - the role element is not needed here for your main section.

    Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.

    Context:

    <section class=`image-container`> - I learned all web pages are initially going to search for a <H1> element, to basically structure the page under this (main) idea. It also searches for a sub section (h2-h6) to help structure other sections. You only need 1 sub section if theres other information.
    <h1> is like the book title <h2-h6> This is like title for a new chapter .

    ** ALSO check your repo for this upload. It sends me to the product-card-preview repo you have

    Marked as helpful
    0
  • Mauger•210
    @mauger1998Submitted about 2 years ago

    Okay so this is the second thing Ive ever built with no tutorial and Im very happy with it, only problem is i feel like I styled it all pretty randomly rather than in order and theres probs some styles in there not doing anything also the html feels very cluttered, I have no idea how to set it up for mobile either I havent reached that yet in the course im taking any advice is welcome!

    Second ever time I built something with no tutorial very happy!

    1
    Antonio Santiago•90
    @AblueremotePosted about 2 years ago

    Well done! I am also a beginner and know putting a project together feels great.

    Take my advice with a grain of salt, I am trying to learn to teach what I know (it could be wrong)

    • I notice your .card class has a height element. You may not need this -Your elements inside can define your height for you ie. your <img has a height of 400px so it will default to that height.

    If you right click and inspect your browser, I go through my elements to see what attributes is doing what exactly. You can try this to see what elements are not needed. Basically cleaning your code some.

    The .card height is one i found. There is another in the img class. Hope this helps

    0
  • Antonio Santiago•90
    @AblueremotePosted about 2 years ago

    Congrats on your first project. My suggestion is to start w/the ACCESSIBILITY ISSUES. I just dealt with the same issues. Instead of using divs , try using main, h1, and p. Main as your main component for your body. H1 for the bold text and p for the secondary text. Start there, you will have to tweak your CSS containers

    Marked as helpful
    1