@Mamin0679
Submitted
@Abimzz
@Mamin0679
Submitted
@Abimzz
Posted
Firstly, I want to commend you on the excellent work you did on the project! Your attention to detail and overall design approach are commendable, and it’s clear that you put a lot of effort into creating a functional and visually appealing site.
While the project is strong, I noticed a few areas where improvements could be made:
Background Color
--Very-dark-blackish-blue: hsl(219, 29%, 14%);
should be changed to --Light-grayish-blue: hsl(210, 46%, 95%);
. This adjustment will create a lighter and more inviting atmosphere for the site.Breakpoint Adjustments
Class vs. ID Usage
Header Syntax
.header
, consider using a more semantic approach by applying syntax such as h1, h2, h3
. This not only improves the structure of your HTML but also enhances SEO and accessibility.Font Weight for Header
.header
should be set to either font-weight: 500;
or font-weight: 600;
. This adjustment will help achieve a more balanced and visually appealing text hierarchy.Overall, you’ve done a fantastic job with the project, and with these adjustments, it can be even better. I appreciate the hard work you’ve put into this, and I look forward to seeing how you implement these suggestions. Keep up the great work!
What are you most proud of, and what would you do differently next time?
I used Grid to implement the layout. I wasn't very skilled using Grid but this time I tried anyway and managed to complete the challenge.
What challenges did you encounter, and how did you overcome them?
Designing the layout was a bit tricky. Specifically, the way the first and last card sits between row. I didn't know how to implement this so had to learn about Grid. After learning about the Grid and few trials and errors was able to solve it.
What specific areas of your project would you like help with?
Any suggestions is appreciated.
@Abimzz
Posted
first well done on the site, your code was a little more involved than i was expecting but it turned out just fine
@Abimzz
Posted
First and foremost, I want to commend you on the great job you've done with the site! it’s clear that you’ve put a lot of effort into this project.
I did notice a few areas that could benefit from some adjustments:
Border Radius on Images
border-radius
property is currently applied to all four corners of the images. It would be more visually appealing to apply it to only two sides, which can create a more refined look.Card Body Height
.card-body
should be adjusted to match the height of the image. This will create a more cohesive appearance and ensure that the layout is balanced.Image Alt Text
alt
attribute in the <img>
tag is essential for accessibility. It should be used to describe the image in case there is an error in loading it. This not only improves accessibility for users with screen readers but also enhances the overall user experience.Breakpoint Adjustments
Mobile View Spacing
Cart Icon Color
color: black;
style applied. Changing this to color: white;
would enhance visibility and align better with the overall design aesthetic.Overall, your work is commendable, and with a few adjustments, it can be even better. I appreciate the effort you've put into this project, and I look forward to seeing how you implement these changes. Keep up the great work!
Marked as helpful
@ivan-josef
Submitted
What are you most proud of, and what would you do differently next time?
i found thist challenge more difficult than the previous one, but i managed to complete it.
What specific areas of your project would you like help with?
I didn't understand why I had to modify only the widht element of my container item
@Abimzz
Posted
First and foremost, I want to commend you on the excellent job you've done with the site! The styling of the list markers is particularly impressive. I found it to be visually appealing and well-executed. Your example has provided me with valuable insights that I can apply to my own code, so thank you for that!
Areas for Improvement While the site has many strengths, I did notice a few areas that could benefit from some adjustments:
Card Padding and Max-Width
Mobile Responsiveness
Overall, your work is commendable, and with a few adjustments, it can be even better. I appreciate the effort you've put into this project, and I look forward to seeing how you implement these changes. Keep up the great work!
Marked as helpful
@BlasVernazza06
Submitted
@Abimzz
Posted
the font weight used for the social links was not correct. font-weight: 600; should have been used instead of font-weight: 600;. other than that the rest of your code was masterful written.
@Bichesq
Submitted
@Abimzz
Posted
First of, nice work on the project.. there are a few minor things i would like to point out:
Most of the other issues with the site can be fix by using flexbox, so i recommend that you look into flexbox.. this should help you start https://css-tricks.com/snippets/css/a-guide-to-flexbox/
keep coding, keep improving.
Marked as helpful