@dvsantaSubmitted over 1 year ago
Hi! This is my first Frontend Mentor Challenge.
Please provide me any Feedback, everything is welcome.
I have questions about the folders methodology. Is it correct?
Thanks
Abraham
@AbeeujahAll comments
- @AbeeujahPosted over 1 year ago
Hello, you submitted a nice solution and Here's some helpful tips to help you improve it
HTML :
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
0 - @NarakornBSubmitted over 1 year ago@AbeeujahPosted over 1 year ago
Hello, you submitted a nice solution and Here's some helpful tips to help you improve it
HTML :
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Use appropriate header tags to give semantic value and improve accesibility in your page starting from <h1> - <h6>
Marked as helpful0 - @NsohanSubmitted over 1 year ago@AbeeujahPosted over 1 year ago
Hello, you submitted a nice solution and Here's some helpful tips to help you improve it
HTML :
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Marked as helpful1 - @maxkdavisSubmitted almost 2 years agoWhat are you most proud of, and what would you do differently next time?
What I would improve for next attempt:
-
Using CSS variables
-
Better understanding of Flexbox
-
Add Responsivness
@AbeeujahPosted almost 2 years agoHello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).
Alt text 📷:
Images Should Contain Alt Texts as it Helps Assistive Technologies tell the Value of the Image.
The alt attribute should explain the purpose of the image. Upon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io If you want to learn more about the alt attribute, you can read this Article
Marked as helpful1 -
- @adgel1Submitted almost 2 years ago@AbeeujahPosted almost 2 years ago
Hello here are some suggestions to help you improve your nice solution you have up there
HTML Accesibility:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
0 - @Kure-ruSubmitted almost 2 years ago
Feedback welcome.
@AbeeujahPosted almost 2 years agoHello, Nice Solution you've got.. Here's some tips to improve it
HTML :
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS : You can use Intrinsic Sizing or an accurate Extrinsic Sizing to handle Overflow on your component
Marked as helpful0 - @AyomidejhaySubmitted almost 2 years ago@AbeeujahPosted almost 2 years ago
Hello, you submitted a nice solution and Here's some helpful tips to help you improve it
HTML :
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Marked as helpful0 - @dsfhigorSubmitted almost 2 years ago
O projeto aparenta ser fácil até o momento de começar a codar, valeu o aprendizado.
@AbeeujahPosted almost 2 years agoHello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).
Marked as helpful1 - @Kareem-kbSubmitted almost 2 years ago
what challenge me is to center everything in the center of the page.
@AbeeujahPosted almost 2 years agoHello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Alt text 📷:
Images Should Contain Alt texts for Screen Readers to be able to interpret the Image, you can read more about alt text Here CSS 🎨:
To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS Here. You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers. Popular CSS resets: Normalize.css Here
Happy coding!
0 - @jadefurtadoSubmitted almost 2 years ago@AbeeujahPosted almost 2 years ago
Hi Jade, Nice solution you have up there..
Here's a way you can improve it..
HTML:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
You can learn more about accesibility Here
Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).
Marked as helpful0 - @NeciberkolSubmitted almost 2 years ago
Any Comments and help will be great , thank you so much for any advice , Thats my first time trying -root so i got help about it from youtube- Also Used a Ready Css Reset Belongs to Josh COMEAU which is solved my many many problems .
@AbeeujahPosted almost 2 years agoHTML Accessibility:
Use the <title> tag to provide page title of your site, you can learn more about
titlebest practices HereUse the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information. you can learn more about accessibility Here
Marked as helpful1 - @valmirsantanepeSubmitted almost 2 years ago@AbeeujahPosted almost 2 years ago
Hi Valmir
For HTML Accesibility Fix
HTML:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page. Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information. Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).
1
