Skip to content
OverviewSolutions
32
Comments
22
Abdihafid Adan
@Abdul400

All comments

  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    hey @KaiPereira

    thank you for your feedback. I will be considering them for my next challenge. :)

    0
  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    hello @Eman-AbdElZaher, Generally, your work looks really good and is very responsive. However, here are a few things I noticed.

    1. the link to your GitHub code does not work and there is no way of reviewing the code.
    2. I bypassed that by using the view page source in chrome web dev tools and noticed that you gave the hero-desktop image a width and height of 100% which squishes it when viewing devices with smaller width. I would recommend using the image as a background of the right-side and then positioning it accordingly using background-position.
    3. The form placeholder should also be the same color as that of the paragraph. You can edit the placeholder using ::placeholder property.

    Other than that. Good Job!!

    0
  • Anul•90
    @AnulQrSubmitted almost 3 years ago

    Hi All Would appreciate feedback on this please. I'm using a screen size of 375px & 1440px

    Base Apparel coming soon

    1
    Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    hello @AnulQr. I think your work generally looks really good particularly for the desktop view. However, I noticed a few things.

    1. It is responsive but the pages have not been optimized well for mobile devices and tablets.
    2. The responsive layout transitions to quickly to the mobile view too quickly and according to your code, I can see that you started with mobile-first development, which is not necessarily a bad thing. However, you have to consider other devices too. I believe the transition from desktop view to mobile view should be from around 375px, but I usually start around 500px to cater for 'phablets' because phone screens are getting bigger. There should also be tablet devices maybe starting from 500px to around 800px or so. Then the rest is desktop view. kindly consider such devices in your development.
    3. The background does not match the one outline in the design files. consider incorporating it and adjusting it accordingly.

    Other than that, Great Job!

    Marked as helpful
    0
  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    hello @Mhmd-Tarek-Mhmd,

    I noticed that the JavaScript functionality for email validation works only when the email is invalid. as per the design files, I believe you should also have a (green text) notification when the email is valid. I also noticed that the background positioning is a bit off. Use the background-position property to position your background.

    Other than that, excellent work!

    Marked as helpful
    0
  • Sang Le•520
    @sqle157Submitted almost 3 years ago

    My first challenge after a 4 months stop on coding. I hope this can give people inspiration on doing more challenges.

    Feel free to give any feedbacks if you guys want!

    NFT Preview Card Component

    2
    Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    hi, @sqle157.

    Generally, everything looks good and scalable. However, I think you have to work on the hover states for instance, use cursor: pointer on the hover states for the avatar image, and also the name in the NFT component. Also, to allow for accessibility, kindly wrap the primary contents in a main html attribute. On the same note, provide alt descriptions for your images to also allow for accessibility.

    Otherwise, nice Job for having a clean and readable code!

    Marked as helpful
    0
  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    will definitely do so. Thank you for sharing your resources. I will definitely look into them.

    0
  • David Turner•4,150
    @brodiewebdtSubmitted almost 3 years ago

    This is my final version of the Easybank challenge. This was my toughest challenge yet. Because of the way I built the main nav I couldn't use border-bottom for the hover state without ruining it. I used a position:absolute "hack" to display the borders so they don't line up perfectly. Any feedback would be appreciated.

    HTML, CSS, CSS Variables and Flexbox, Grid and Javascript

    4
    Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    I'd really like to know what your web dev setup looks like. I like how you develop so quickly and they still look so good.

    0
  • David Turner•4,150
    @brodiewebdtSubmitted almost 3 years ago

    This is my final version of the Easybank challenge. This was my toughest challenge yet. Because of the way I built the main nav I couldn't use border-bottom for the hover state without ruining it. I used a position:absolute "hack" to display the borders so they don't line up perfectly. Any feedback would be appreciated.

    HTML, CSS, CSS Variables and Flexbox, Grid and Javascript

    4
    Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    I'm not sure how you develop your solutions so rapidly, I see you uploading in quick successions. Do you use bootstrap?

    0
  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    Thank you so much, this solved my issue. I thought making the color above the picture and giving it a lower opacity was the only way to do so. I'm still not sure how your solution works, but it works. Could you please explain to me? unless the bg-intro-desktop.png itself has a transparent background, I'm not sure how the hsl(0, 100%, 74%) can be seen.

    0
  • David Turner•4,150
    @brodiewebdtSubmitted almost 3 years ago

    This is my final version of the Easybank challenge. This was my toughest challenge yet. Because of the way I built the main nav I couldn't use border-bottom for the hover state without ruining it. I used a position:absolute "hack" to display the borders so they don't line up perfectly. Any feedback would be appreciated.

    HTML, CSS, CSS Variables and Flexbox, Grid and Javascript

    4
    Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    I have to admit this looks awesome!!

    0
  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    That solved my issue. Thank you!!

    0
  • Abdihafid Adan•800
    @Abdul400Posted almost 3 years ago

    hello @shashankbhat2, your solutions looks great and the hover states are exactly as depicted. However, there are some things that I noted:

    1. clear your accessibility report.
    2. the page is not responsive for mobile i.e., 375px. I think you should work on making it responsive for mobile devices.
    3. the avatar does not have a white outline by default. It should have an outline on hover. So add a hover state to the image and give it a white outline.
    Marked as helpful
    1