All comments

• 

  averagedeveloper• 40

  @mpgithubcode

  Submitted about 2 years ago

  I'm getting more and more comfortable with the flexbox and positioning with them!

  I will definitely redo this one. I am on the free tier currently but I plan on upgrading. Since I don't have access I get a little frustrated when trying to recreate the sizing and formatting from the picture.

  For example, I could not see or find the color that was bordering around the avatar picture, and the default text included in the design docs where too small

  I still need to work on:

  • media queries
  • hover states

  

  Flexbox NFT Component

  1

  30

  

  Abdallah Ahmed• 60

  @AbdallahGO

  Posted about 2 years ago

  media queries and hover they like a condition . for example when you write :

  ' div:hover => it means when you hovering div box something happens '

  BUT

  div:hover div2 => it means when you hovering div box something happens to div2 and it must be div2 inside div to work '

  and about media queries, it's not more important than hover but you will a lot in make fonts or customize your website in different screen sizes

  I hope that was helpful ✌️

  0
• 

  Damian• 10

  @Damianeks

  Submitted about 2 years ago

  I would be happy about feedback!

  

  QR code component

  3

  30

  

  Abdallah Ahmed• 60

  @AbdallahGO

  Posted about 2 years ago

  Hi Damian . I see your project and it was perfect, but this code :

  <div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://www.frontendmentor.io/profile/Damianeks">Damianeks</a>. </div>

  you should separate it from <div class="text">.....</div> and put it outside the container to do this you can make :

  <div class = BIG container> put your container + all .attribution </div>

  I hope that helped you

  Marked as helpful

  0