Skip to content
OverviewSolutions
11
Comments
6
Abdalla Rahmah
@AbdallaRahmah

All comments

  • Abdalla Rahmah•260
    @AbdallaRahmahPosted about 2 years ago

    Hey Kelpy, congratulations on completing the challenge! You did a great job 😉

    Let me give you some little tips for optimizing your code:

    • use the main tag insted of the div tag.
    • add a transition on your elements that have hover action to make smooth.
    Marked as helpful
    1
  • Neil Kanakia•300
    @neilk17Submitted about 2 years ago

    📍Things that were difficult:

    • Getting a downward triangle below the share button: Not sure what the best approach is to achieving this.
    • Getting a smooth transition to a responsive design: Was not able to create the right sizing in the mobile version of the site.

    Would love to hear any feedback 😀

    Article Preview Component

    2
    Abdalla Rahmah•260
    @AbdallaRahmahPosted about 2 years ago

    nice work Nell, i like your work and i have some ideas for you:

    • instead of adding a large padding to the body element you can add min-height: 100vh and justify content: center this will help you center the main element.

    • also you can remove the article-container div and duplicate its styles to the main tag.

    best of luck for you.

    0
  • Abdalla Rahmah•260
    @AbdallaRahmahPosted over 2 years ago

    nice work Shann you can lern about css flexbox to center the card and give the card a flexible width value that will make it responsive.

    1
  • Bazthos•430
    @BazthosSubmitted over 2 years ago

    Hello Everyone !

    This is my second project using JS.

    I was looking for a way to make the answers to the questions appear smoothly, if you have any leads (CSS or JS ?).

    It's a little messy but I've improved my understanding of the DOM and how to navigate within it.

    Thanks in advance for looking at my solution !

    FAQ Accordion app

    1
    Abdalla Rahmah•260
    @AbdallaRahmahPosted over 2 years ago

    nice work

    1
  • Abdalla Rahmah•260
    @AbdallaRahmahPosted over 2 years ago

    Hi @brunafelix79, nice work but you can use semantic elements to improve your SEO.

    Marked as helpful
    0
  • Abdalla Rahmah•260
    @AbdallaRahmahPosted over 2 years ago

    nice work Dinah, i recommend you to use flexbox insted of position to center elements, also you use the box-shadow property to add nice look to the box.

    0