@guiwebberSubmitted about 1 month ago
Latest solutions
Latest comments
- P@AbbyHumphreysPosted about 1 month ago
Great Work.
Two things that could improve it are:
- The repayments are two big and spill over to the next line.
- When you calculate with repayments for example, you can't automatically recalculate with interest only using the same inputs.
Looked lovely overall though
Marked as helpful0 - @kotyba-kmSubmitted 2 months agoP@AbbyHumphreysPosted 2 months ago
Hi,
Well done with this project. It looks lovely.
Little suggestions I would make would be:
- Make the overall component smaller. It's quite a bit bigger than the challenge design
- Maybe look at some of your class names and make them more reusable. For example, you could change 'yourResult' to 'card' and then you could use it elsewhere in the site (if it was real) and it would still make sense.
- remove some of the margins on smaller screens in the summary section to get the text more room.
Keep going, you did great.
0 - @FoPiSubmitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
When I compare design with my screen (using Chrome in mobile simulation), the 375px didn't match with the provided image 375px. Then I accepted the Chrome's 375px.
P@AbbyHumphreysPosted 2 months agoI liked how you set out the font sizes. Looks like clean code
0 - @slackwareeSubmitted 12 months agoWhat are you most proud of, and what would you do differently next time?P@AbbyHumphreysPosted 2 months ago
Hi, Really like the way you've done this and your use of sass. Only small comment I would make is about using semantic HTML - maybe using section to encompass the card as it would be used on a bigger site.
0
