Skip to content
OverviewSolutions
3
Comments
3
P
Aaron Deimund
@Aaron-Deimund

All comments

  • P
    Aaron Deimund•70
    @Aaron-DeimundPosted about 1 month ago

    I can't really comment. I don't see any of your styles in the repo. Am I missing something? Looks like base, component, and utilities are imported but I don't see them anywhere.

    Marked as helpful
    0
  • P
    Aaron Deimund•70
    @Aaron-DeimundPosted 3 months ago

    I can't comment on this one because I can't see the code. It looks like the repo doesn't exist.

    0
  • ardolynk-reborn•160
    @ardolynk-rebornSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    Despite my long-term programming experience, I still need more page-proofing practices before diving deeper into frontend development.

    What challenges did you encounter, and how did you overcome them?

    Flexboxes and viewport sizes could be helpful to align items properly. Here we put attribution info to the page bottom and center the card within the rest.

    Flexboxes and viewport sizes could be helpful to align items properly. Here we put attribution info to the page bottom and center the card within the rest.

      <div class="main">
    <div class="content">
      <div class="card">
        #card content
      </div>
    </div>
    <div class="attribution">
      #attribution content
    </div>
  </div> 

    .main {
  height: 100vh;
  display: flex;
  flex-direction: column;
  align-items: center;
}

.content {
  height: 100%;
  display: flex;
  flex-direction: column;
  justify-content: center;
}

    QR code component solution

    1
    P
    Aaron Deimund•70
    @Aaron-DeimundPosted 3 months ago

    Great job! Have you ever experimented with CSS custom properties? There's several places where you have the spacing defined in a padding or margin. It's not too bad on a small project like this, but I find when things get a bit bigger it's a real hassle to go through and change it in all the places.

    Marked as helpful
    0