I learned a few things in this challenge.
- Bootstrap is quite restraining in terms of fine-tuning CSS properties.
- Hover overly icon effect.
I learned a few things in this challenge.
Good, clean and polished. What else can one expect from such a challenge? Good work pal! I would have said mobile responsiveness but it looks great even on small screens
I didn't find a way to make previous and next projects appear on the page in the My Work section, so I would appreciate any ideas on this, as well as anything else that could use some work. Thanks!
Hey! I don't have pro but attempted this challenge nonetheless (courtesy of you for the assets) Here is the github link live url
The way I sovled the issue, was to just align all the images with a flex, justify them on the center and just translate the container by the width of a image on the arrow click
I feel like the tooltip could be improved upon, its just that with my implementation (tailwind-in-html-in-js) leaves not a whole lot of flexibility, any input is appreciated
Holy hell I just saw the 40 html mistakes, but most of them seem to be the doings of tailwind and webpack, so I don't think I can fix em
SCSS is definitely a little messy, but was able to get the job done.
One thing I wasn't sure about is, the box on the desktop view, doesn't shrink/move when the view gets adjusted, I'm not sure why. Any ideas?
Thanks!
this is because of the way your app is centered and the approach, this is why you should opt for a mobile first approach, on mobile do something like .card { width: 80%; max-width: 700px}
and done, simple as that, no need to worry about the sizing, and also, when centering elements horizantally within the body use margin: 0 auto
and use position absolute for the vertical centering, sorry if my comment is a bit vague, feel free to ask me anything
All inputs are welcomed!
hey man great design, just one small suggestion, (this is something even I do and am trying to avoid) that is hover, I would say you should add a :active
animation to your button to make it clicky both on mobile and deskop. The problem with a hover is that it is sticky on mobile, which makes it irritating, in my newer projects I avoid using hover in most cases, especially where the effect is visible (box-shadow for instance) instead I try and add active
animations that trigger when the button is clicked.
The overlay proved tricky. Got it working(a bit) but the svg looks faint. The alignment of the price and days left don't look so accurate.
Your design is great just a little suggestion -- add a media query for smaller screens like so --
@media only screen (min-width: 375px) {}
and here you can maybe adjust some fonts and the width of the card.
I had fun adding animations when the data is load via the data.json file. Feel free to give any feedback if there are some stuffs I can improve!
The design looks spot on! just one small thing, I think the grey bar is meant for the highest value
Hi,
I need help with my JavaScript.
As you can see in my script I have three functions (dailyCards, weeklyCards, and monthlyCards) I'd like to ask if I can make it only in one function because they have only small differences.
Thank you so much for helping out.
Good job on breaking down your JS into functions, that is a good practice, so, here is a simple fix; remove all the other functions and just have a single one getCard(date)
where the date is either daily, monthly or weekly, then simply in your template replace ${item.timeframes.daily.current}
with ${item.timeframes.[date]['current']}
(do this will all the references) and voila
Hey! Even I just completed this challenge, great work, but the mobile spacing is a bit off Also, a quick tip, you should use absolute positioning in the "Made by ____" this will prevent that scroll
ALL feedback is welcome . I also did YouTube video for this challenge , I also want feedback for this : https://youtu.be/EknT7SD5-f0
Hey, the only tip I have is that you should use bem naming conventions in your html, that makes it cleaner and easier to read, for you and other devs. Here is a BEM 101
I checked out you source code and its' really well structured and organize, good job. I would recommend you add a media query for the card component to make it usable on smaller mobile screens
I had to cheese things a bit since I had some difficulties with dynamic styling with Tailwind and React, but it doesn't seem to have impacted the production build.
How does one ensure that they are building an accessible website whilst using React?
Hey man! I was curious to see your source code, since I myself just started using tailwindcss, but I couldn't find the actual source, instead it was the minified production code; I would suggest you keep your src folder separate and gitignore the destination folder, and simply add a build command to netlify. You can reach me out via twitter or mail and I can help you set it up. You can also take a look at my repo of fem projects