React -Testimonial Grid

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi Luis, It looks like this still needs some work to get it looking like the design. Notucj, just some tweaking of the grid probably. Also the writings so small on mobile I can't read it, so maybe look at that at the same time.

  Im curious why you've chosen to do this in React tbh? Some of the bigger Challenges are more suited to a componen framework I think.

  Also curious why you've gone for a 12 column grid? (I think that's what I saw in code, may be wrong though)

  1

  ---

  

  Zuzki•180

  @LuisDGraciaPosted almost 4 years ago

  @grace-snow Hi, first of all thanks for the comment, it is true about the font, I had issues with the font size, it looked bigger while I was developing the challenge and was overflowing with bigger font size, I'll fix that.

  I used React because I'm practicing it and Styled Components too, I could have done the challenge with vanilla HTML CSS, I want to learn Angular and Vue, so I'll remake the challenge with them at their time.

  And for last, you are right I used 12 colum grid since I feelt that the desing would fit better like the proposal (and gave more space to work).

  0

  

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  That's cool @LuisDGracia ☺

  I'd still say this should be a 4 column (or 6 if used for the whole page). The one of the main goals of css grid was to empower designers and developers to break out of thinking of designs as a 12 col -grid and allow them to build custom but predictable grids as needed. It feels unnecessary having all those extra columns

  1

  

  Zuzki•180

  @LuisDGraciaPosted almost 4 years ago

  @grace-snow thanks you for the advice, I'll remember it for future projects

  0