Design comparison
SolutionDesign
Community feedback
- @rohitd99Posted over 1 year ago
Hello Rohit, from Rohit 😁
Congrats for completing the challenge.
I have but a few suggestions for you.
- You have used
article
as semantic element correctly so I'd recommend usingmain
too instead of thediv class="container"
since the card is the main content of this page. - Secondly I see you've used
div
for the background image I'd say you can usebackground-image
property on your body for the same, since those images don't have any meaning this should be better. Here's a video from Kevin Powell that shows you how to use multiple images as background.Video
Hope it helps
0 - You have used
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord