ww

Community feedback

• 

  Pablo Hernan Obrach•120

  @pablo-obrachPosted over 1 year ago

  Congrats on finishing the challenge

  The HTML looks good, but should be better to have the script in a different file insted of inside the HTML because if you need to add more scripts will be a madness to do it inside the HTML.

  The layout looks good but not exactly like the image provided by frontend Mentor, a good way to improve it s to follow the most accurate way the image given to you (in a real job that image it's made by the UX/UI desinger and it's approved by the client beforehand).

  The script logic it s fine but there s a BIG problem with the variables. You should never use var to asing a variable . That s because all var variables are at a global scope no matter where you used them and that can be an issue in a bigger script. Always use let or const at your script. Also the function onclick it s not a very well usage for the functions at the script . It s way better to use an eventListener() for the buttons or stuff you want to add a function.

  The layout for both screen sizes looks really good, at the desktop view you forgot to add the hover effect for the button before it will send the email wich also has a box-shadow property. Also if you check the images at the desing folder , in the active desktop image you can see that when the email it s not valid the placeholder should be transparent red and the border for the input also should be red as well as the invalid message.

  At the valid modal there 's a writting mistake here "Please open it and click the button inside to confirmyour subscription" confirm your subscription should be spaced. Lol that s a common mistake and nothig to worry about .

  Hope my feedback was useful for you, have nice day!

  Marked as helpful

  0