With HTML, CSS and Flexbox

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey Tobi, congrats on submitting your first solution! You've done a really good job. Your code isn't very messy at all! After having taken a look I've got a few pointers that will hopefully help:

  • For your . heading class, I would recommend not using a section here. A section is typically used to group a larger collection of themed content. For example, a testimonials section on a page. For this smaller grouping of content, a div would be absolutely fine.
  • You've got h1 and h3 headings but no h2. Be sure to avoid skipping heading levels unnecessarily, as this can cause accessibility issues.
  • You don't need the div wrapping the anchor tag. You could just style the anchor tag directly.
  • In the Why Us area, I'd use a ul with li elements to create a list instead of having separate p tags for each item.

  You've done a really good job. Let me know if you have any questions 🙂

  2

  ---

  

  Tobi-dev99•200

  @Tobi-dev99Posted almost 5 years ago

  @mattstuddert Wow,that was very helpful! Thank You for sparing some time and effort to review my solution.Those were really some pointers.I'll keep those in mind when taking on next challenge.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @Tobi-dev99 you're welcome, Tobi! Happy to help 🙂

  0
• 

  Saurav Chamoli•370

  @sauravchamoli17Posted almost 5 years ago

  Well done!on your project.The improvements you can make in this project are: 1. the per month text should be centered with related to the $29 text.Add a box shadow and hover state to your sign up button.Add a box shadow and border radius to your main container. Move the why us subtext in an unordered list instead of an paragraph and remove padding from them.

  Keep up the good work!

  2

  ---

  

  Tobi-dev99•200

  @Tobi-dev99Posted almost 5 years ago

  @sauravchamoli17 Thank You for sparing some time and effort to review my solution.This wad really helpful. The reason I used paragraph instead of <ul> because, I was not able to align "Why us" h3 and <ul>.

  0