Where in the world?

Community feedback

• 

  Piotr•80

  @dyrpitPosted about 2 years ago

  Hi,

  Nice job, it looks very nice. However try to fix some bugs, the whole "Back" button should be clickable not only arrow inside it. Since you already fetch all countries try to persist this data in your app. This will prevent multiple unnecessary request to rest api when using search bar. Or if you want to fetch data every time someone use search bar, try to use debounce. It will limit amount of request to api.

  Marked as helpful

  1

  ---

  

  Baliram•260

  @0ME9APosted about 2 years ago

  Hello @dyrpit

  First of all, Thank you for your suggestion bro...

  But because it was my third or fourth react project so I just wanted to create/learn. And now I understand a little bit how REACT works I'll implement and will fix that bug as soon as possible.

  Thank you one more time you gave me your valuable time, And taught me something new.

  0
• 

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  hey @0ME9A😄, congratulations on completing the challenge💯🎉 here are a few things to improve your site...

  1.Firstly when we hover on a country the country-div is not clickable only the title of the country is clickable which is not a good user-experience.. tip: you can add a css scale on the country-div along with while making the whole div as clickable.

  2.on the light mode you can add a shadow to the country-divs.

  3.The thing which seems to missing inside a country page is the border-countries which you can add...

  every thing else seems to be working happy coding🔥🔥💯💯

  0