Where in the world

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi TheHunter, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add header tag and wrap the nav for improve the Accessibility
  • use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the flag images and not simple "flag" for all
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the span container of image
  • use ul element for the details text of country instead of multiple span
  • instead of span for the details text use p
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"

  Hope this help! Happy coding 😉

  Marked as helpful

  0