What a great learning experience! I also used sass for the fist time

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @AGsPortfolio 👋🏻

  I have some suggestion to help you fix the accessibility, HTML and some other issues.

  • First, you should never give a class to html because it's a bad practice. Just select it by its name.
  • Next, in your markup, <section class="Coming-soon">...</section> should be <main class="Coming-soon">...</main>.
  • Also, avoid inline styling like so, <img src=logo.svg alt=logo width=35% height=35%>, it's also a bad practice and can cause some problems down the line. Just give it a class and work in your CSS file. These will fix the accessibility and HTML issues. Don't forget to generate a new repot once you fix the issues.
  • One last thing, add cursor: pointer; to the button and work on JS to make the email disappear after submission.

  I hope this was helpful 👨🏻‍💻 overall, you did a good job, keep practicing, you got this. Cheers 👾

  Marked as helpful

  0

  ---

  

  AGsPortfolio•60

  @AGsPortfolioPosted about 3 years ago

  @kens-visuals Thanks for your tips, this helps me to go further and beyond my knowledge. I really like the pointer en clearing the email address.

  Many thanks!

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @AGsPortfolio you're welcome 😇

  0
• 

  Carlos•1,110

  @Carlos-A-PPosted about 3 years ago

  Hello,

  • So I noticed that you have some margin of 8px on your body element so you can remove that with margin: 0;
  • Also you could change the styling of the input element's background and border instead of adding a background and border to the form element. Then one way you can move the button into the input is with absolute positioning. Hope this helps and happy coding!

  Marked as helpful

  0

  ---

  

  AGsPortfolio•60

  @AGsPortfolioPosted about 3 years ago

  @Carlos-A-P Thanks for your feedback!! The body margin bugged me, so thanks for the tip I could not get the button into the input field with absolute positioning, but I can live with that. Cheers!

  0