@john-mirage
Posted
Hello,
I recommend you the BEM css methodology to organize your code.
Could you recommend me the right way of structurize my css code.
@john-mirage
Posted
Hello,
I recommend you the BEM css methodology to organize your code.
@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
QR iMAGE ALT TEXT πΈ:
alt
attribute which should explain the purpose of the image
.alt
with qr_code
is not even explaining for what the QR image need to be used.alt
with meaningful text which explains like QR code to frontendmentor.io
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
@Oluwalolope
Posted
Hey, Great work completing the challengeπ. I have a few suggestions
Don't use Pixels for Font-Sizing: Pixels are absolute values. They do not vary, if a visually impaired person is trying to go through your site they may need to increase the font size in their browser settings, but that is where the problem comes in. The reader won't be able to increase the font size of the text if it is in pixel. That will affect the user experience. It is best to use rem
instead of px
for fonts. With rem you give the power over to the user to adjust the sizing of texts to make it readable. By default 1px = 0.0625rem
. In your code I noticed you used 15px for the paragraph. Instead use 15 * 0.0625= 0.9375rem
Your CSS Code is clean but I'll advise you to add comments to your code to make it easier to understand what each code is for
Then it is often considered best practice to use BEM notation for CSS sheets : To find out more on BEM check this site BEM 101
Once again Congratulations on completing the challenge. I hope you found this helpful π
Happy codingπ¨βπ»
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord