Website using html, scss, BEM, mobile first workflow

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted over 3 years ago

  Hi

  This looks a little broken for me on mobile with some white space at the top of the card. And on mobile landscape all the content is cut off. I’ll add some screenshots to slack so you can see what I’m seeing

  Html semantics need a little work but not far off

  • this card shouldn’t have a header element, especially if it only contains a decorative img. This whole card could be an article if you wanted (no section or header needed)
  • decorative images like the background pattern should either be background images in css, or have blank alt text if in the html
  • the image of victor is a meaningful image and should be in the html with alt text
  • the stats need to be 3 bullet points in an unordered list. Never have text in a div or span alone, always wrap in a meaningful element

  I hope this helps

  Marked as helpful

  1

  ---

  

  Juan David Osorio Ortiz•160

  @JuanDa15Posted over 3 years ago

  @grace-snow Hi, thank you so much, i will correct that

  0