Website using HTML and CSS

Community feedback

• 

  Mohamed ELIDRISSI•455

  @elidrissidevPosted about 3 years ago

  Hey! Great job with this one! I actually have 5 things 😅:

  • Avoid skipping heading levels, you went from h1 to h4. You should always go from 1 to 6. You can always style them differently if they don't match your design.
  • I would wrap <div class="attribution"> inside a footer element since it's more meaningful.
  • For the illustration image, since it's purely for the look, I would keep alt empty to make it clear for assistive technology that it's a decorative image so they won't read the alt text.
  • Consider using classes to style your HTML elements instead of directly referencing them, it's reusable, more readable and overall a better practice for bigger projects.
  • I would stay away from absolute units like pixels because they're not responsive and don't scale when browser's font size increases/decreases.

  I hope this didn't overwhelm you. Good luck!

  Marked as helpful

  0

  ---

  

  Ivan•365

  @Frontend-WizardPosted about 3 years ago

  @elidrissidev thanks for the helpful tips.

  0