Webpack, PUG, BEM, SCSS, Responsive, Mobile First URL Shortening API

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Good work on the layout, haven't tried this challenge so I don't know if the shortener must work or not. So for the UI, desktop is good and the mobile view is good as well. A suggestions would be that

  1. Center align properly your navbar links in mobile view, since right now, it is not aligned properly.
  2. Well I toggle to device in developer tools, I can scroll to the right side and upon looking further, your hero images is the one causing that, it would be awesome if you add overflow: hidden to your hero__img__wrapper selector so that it would cut off the excess part of the image in its right side which cause the scroll.

  Other than that, great work^^

  1

  ---

  

  nmorajda•945

  @nmorajdaPosted over 3 years ago

  Shorten it work :)

  0
• 

  nmorajda•945

  @nmorajdaPosted over 3 years ago

  Thanks for your comments.

  You're right an address shortener must work. So I still have some work to do :)

  1. Corrected.
  2. Corrected.
  3. Errors from the report corrected.

  0