Web page with responsive desing and flexbox

Community feedback

• 

  John•410

  @MiyaoCatPosted 9 months ago

  Nice work! Not much to add, just a couple things I quickly noticed.

  • It looks like your box-shadow around the Payment button is off. Here's a handy article that explains the numbers. https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
  • An even easier tool is Chrome's inspect too. If you inspect the Payment element then click on the little purple box next to the box-shadow declaration, you can drap and pull the box shadow and it'll automatically update the numbers.
  • I see you used main as the container. However this is a component. I like to think of components as a piece of the page that can be placed anywhere on the page. I would add a secondary container to the main, I typically just make a div and give it the class name of whatever the component is I'm building.
  • When I pull the window wider than 1440px, the background wave cuts off. Also, it looks like the button half is white when it should be blue. I went back and looked at my solution and I didn't even add the wave. Oops!

  Otherwise, looks great! Keep it up!

  Marked as helpful

  0
• 

  John•410

  @MiyaoCatPosted 9 months ago

  Nice work! Not much to add, just a couple things I quickly noticed.

  • It looks like your box-shadow around the Payment button is off. Here's a handy article that explains the numbers. https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
  • An even easier tool is Chrome's inspect too. If you inspect the Payment element then click on the little purple box next to the box-shadow declaration, you can drap and pull the box shadow and it'll automatically update the numbers.
  • I see you used main as the container. However this is a component. I like to think of components as a piece of the page that can be placed anywhere on the page. I would add a secondary container to the main, I typically just make a div and give it the class name of whatever the component is I'm building.
  • When I pull the window wider than 1440px, the background wave cuts off. Also, it looks like the button half is white when it should be blue. I went back and looked at my solution and I didn't even add the wave. Oops!

  Otherwise, looks great! Keep it up!

  0