Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Web page using HTML, CSS custom properties and Flexbox

@yasminsilva1

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@JamesLaviron

Posted

  • Does the solution include semantic HTML?

Yes it does, nice ideas. Loved the way you used classes and variables.

  • Is it accessible, and what improvements could be made?

yes it is accessible. I would pack texts in a container that handles most of padding stuff.

  • Does the layout look good on a range of screen sizes?

It looks good.

  • Is the code well-structured, readable, and reusable?

It seems so, I would personally have sticked with HSL.

  • Does the solution differ considerably from the design?

Yes, a lot. Are you using figma? It seems like many values are approximative. Overall it's looking nice :)

Marked as helpful

1

@yasminsilva1

Posted

Hi, @JamesLaviron! Thanks for your feedback! No, I didn't use figma. I made the page looking at the preview and tried to reproduce it as faithfully as possible.

1

@emmanuel-dev3

Posted

The solution include semantic HTML. Work on the styling -h tag and p tag. The screen layout looks good on both mobile of desktop. Work on your code structures. The height is larger than the design.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord