w3school-youtube-how to ...

Community feedback

• 

  NitheeshKumar C•440

  @NitheeshKumar-CPosted over 2 years ago

  Hi there 😀,

  I can help with some issues. You can make the body content center using flex-box,

  Example for this problem:

  body{
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  and remove margin: 10em 30%; from .QRcode.

  If you think this is helpful please mark as helpful.

  Happy Coding 👨‍💻,

  Nitheeshkumar

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Kamiya, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible remove height from.QR-siz class
  • remove all margin from .QRcode class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • not use <br> for brea the text... make it wrap according to the width it has available
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  1

  ---

  

  kamiya nakami•270

  @kamiya-nakamiPosted over 2 years ago

  @denielden Thanks for the advice and I will use it to improve on the new project .

  1