[W/ DARKMODE] Responsive Tip Calculator App using Vanilla CSS & JS

Community feedback

• 

  Arber Lisaj•340

  @arberlisajPosted over 1 year ago

  Hi @oyasumibella 👋 First I would like to congatulate you on compleaging the Tip Calculator App🧮 and "The entire JavaScript" you said that had me burst out laughing 😂anyways would like to share with you a couple suggestions to improve your solution

  • JavaScript: Never name your variables like this $resetBtn it should be a cleaner and more readable like resetButtonEl or just resetBtnEl
  • JavaScript: Instead of using const like a million times you want to declare your variables like this const firstName = 'Jane' , lastName = 'Doe' , age: 120;
  • UX: If you will work on responsiveness again please make it so it is more repsonsive to smaller screens so i test my websites on an iphone 8 around 370px wide and this solution it is not as good of a UX as on a larger screen like my laptop
  • GitHub: You want to remove the unused files and directories from your github repo like : designes , README-template.md etc

  All in all Great solution 🎉 and i wish you a long time in the community😊

  Happy Coding :)

  Marked as helpful

  1