Design comparison
Solution retrospective
This is my first vue.js project
Community feedback
- @NaveenGumastePosted almost 3 years ago
Hay ! Arnas Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body
<main class="container"></main>
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful0 - @EmmanuelHexerPosted almost 3 years ago
Good work man, keep it up. One tip i can give you is to always
- add
main
tag and wrap the card so that you do not get accessibility issues
Marked as helpful0 - add
- @denieldenPosted almost 3 years ago
Hi Arnas, great job!
Remove all
margin
fromcontainer
class because with flex they are superfluous and after set hisheigth
to100vh
because Flexbox aligns to the size of the parent container.Also add
main
tag and wrap the card for AccessibilityOverall you did well! Hope this help ;)
Marked as helpful0 - Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
- Always Use Semantic HTML instead of
div
like<main>
<header>
, etc for more info
if my solution has helped you do not forget to mark this as helpful!
Marked as helpful0 - Always Use Semantic HTML instead of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord