Vue SFC - Product preview component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution contains some minor semantic issues which may cause accessibility issues.

  ---

  • The old price is not being properly announced, you have used div element for that => <div class="card__info__price__past">$169.99</div>

  ---

  • Actually there's a native html element which comes handy in these situations. it is del element

  ---

  • So you can use like this <del>$169.99</del>

  ---

  • These are the tips which improves the accessibility in real world situations.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Paweł Ciszewski•340

  @kardahimPosted about 1 year ago

  @0xAbdulKhalid I didn't know about this tag before. Thanks for suggestion, I'll use this tag in a future project.

  0