Vscode, Git, HTML, CSS

Community feedback

• 

  dewslyse•3,025

  @dewslysePosted over 3 years ago

  Hello @esthercate! Congrats on your submission. Your solution is very well implemented. Good job.

  • You could center the card to the page by adding the following to the body in css.

  body {
     display: flex;
     flex-direction: column;
     min-height: 100vh;
     justify-content: center;
     align-items: center;
  }
  

  • You could also add semantic sectioning elements to your html. You could change <div class="hero-section"> to <header class="hero-section"> , <div class="main"> to <main class="main"> and maybe <div class="attribution"> to <footer class="attribution">. This will help address the accessibility issues raised in the report.

  Happy coding

  Marked as helpful

  0

  ---

  

  Catherine Vuthi•150

  @esthercatePosted about 3 years ago

  @dewslyse Thank you. I really appreciate your feedback.

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • good work with the meaningful alt values.
  • an h1 is considered best practice in a site and should not be missing. Use css to control the font size

  Happy coding

  Marked as helpful

  0
• 

  GerLC•455

  @GerLCPosted over 3 years ago

  Hello! For the background image, it cant find the image source. In the background-image: url("../images/pattern-background-mobile.svg"); you forgot a dot(.) in the beginning.

  Marked as helpful

  0

  ---

  

  Catherine Vuthi•150

  @esthercatePosted over 3 years ago

  @GerLC Thank you. I have added the second dot(.) and its working.

  0
• 

  Igor•35

  @Igor-van-DamPosted over 3 years ago

  Check the path file. That was my problem.

  Marked as helpful

  0

  ---

  

  Ferrozo•65

  @FerrozoPosted over 3 years ago

  @Igor-van-Dam I have the same problem with the project when I uploaded to github page, the background images disappear

  Marked as helpful

  0

  

  Catherine Vuthi•150

  @esthercatePosted over 3 years ago

  @Igor-van-Dam Thank you. I just changed the path and its working perfectly.

  0