Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Vscode, Git, HTML, CSS

@esthercate

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Why is the background image not showing on live site but on my local site is showing? Any other recommendations on html and css best practices will be highly appreciated.

Community feedback

dewslyse 3,025

@dewslyse

Posted

Hello @esthercate! Congrats on your submission. Your solution is very well implemented. Good job.

  • You could center the card to the page by adding the following to the body in css.
body {
   display: flex;
   flex-direction: column;
   min-height: 100vh;
   justify-content: center;
   align-items: center;
}
  • You could also add semantic sectioning elements to your html. You could change <div class="hero-section"> to <header class="hero-section"> , <div class="main"> to <main class="main"> and maybe <div class="attribution"> to <footer class="attribution">. This will help address the accessibility issues raised in the report.

Happy coding

Marked as helpful

0

@esthercate

Posted

@dewslyse Thank you. I really appreciate your feedback.

0
T
Chamu 13,110

@ChamuMutezva

Posted

  • good work with the meaningful alt values.
  • an h1 is considered best practice in a site and should not be missing. Use css to control the font size

Happy coding

Marked as helpful

0
GerLC 455

@GerLC

Posted

Hello! For the background image, it cant find the image source. In the background-image: url("../images/pattern-background-mobile.svg"); you forgot a dot(.) in the beginning.

Marked as helpful

0

@esthercate

Posted

@GerLC Thank you. I have added the second dot(.) and its working.

0
Igor 35

@Igor-van-Dam

Posted

Check the path file. That was my problem.

Marked as helpful

0

Ferrozo 65

@Ferrozo

Posted

@Igor-van-Dam I have the same problem with the project when I uploaded to github page, the background images disappear

Marked as helpful

0

@esthercate

Posted

@Igor-van-Dam Thank you. I just changed the path and its working perfectly.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord