Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
responseive design
What challenges did you encounter, and how did you overcome them?Making UI responsive
Community feedback
- @MahmoodHashemPosted 4 months ago
Great work on completing the challenge!
However, I have some recommendations to help improve your code:
- Consider using
<main>
to wrap your main content for better accessibility. - For headings, it's best to use
<h1>
to<h6>
tags. - Move the inline styles from the HTML file to the CSS file for better code readability.
Example:
<main> <div class="container"> <img src="./your-img-address" alt=""> <h1>heading</h1> <p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Sint, consequuntur? Sequi dolore repellat praesentium voluptatibus odit? Nam ratione iure, quia eaque eos molestias laboriosam dolores autem, perferendis ex consequuntur suscipit.</p> </div> </main>
I hope you find these suggestions helpful! Overall, great job on your work!
0 - Consider using
- @MaRiiaVoitPosted 4 months ago
- The solution includes semantic HTML.
- <p class="description">Scan the QR code to visit frontendMentor and take your coding skills to the next level</p> - I would make it brighter.
- I couldn’t find the README.md file with a description and screenshots of the site.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord