@DylandeBruijn
Posted
@ZoeInMyDna-code
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it. Props that you didn't gave up and pushed through!
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Would change your image CSS:
.image {
display: block;
border-radius: 15px;
max-width: 100%;
}
So this means that your image will take up the full width of it's container but never will be larger than it's container. I always put this as a base on my images, it scales really well.
-
Try adding the right
font-family
to your solution. -
I recommend not using ChatGPT too much when you are just starting out because you can't tell when it's giving you wrong information. Try to master the fundamentals first of HTML and CSS, really try to understand what goes on under the hood. Look into the box-model, and the cascade for example.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
@ZoeInMyDna-code
Posted
@DylandeBruijn
You really took out time to access the code and the design and brought out constructive feed backs for me.
I would do well to take note of the correctioms and see if I can rewrite some of the codes.
What do you suggest I do when I need a tag and I don't know the name where can I find what to do
@DylandeBruijn
Posted