Vscode, Chatgpt, github

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @ZoeInMyDna-code

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it. Props that you didn't gave up and pushed through!

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Try using semantic HTML elements like main and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • Would change your image CSS:

  .image {
      display: block;
      border-radius: 15px;
      max-width: 100%;
  }
  

  So this means that your image will take up the full width of it's container but never will be larger than it's container. I always put this as a base on my images, it scales really well.

  • Try adding the right font-family to your solution.

  • I recommend not using ChatGPT too much when you are just starting out because you can't tell when it's giving you wrong information. Try to master the fundamentals first of HTML and CSS, really try to understand what goes on under the hood. Look into the box-model, and the cascade for example.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  0

  ---

  

  ZoeInMyDna-code•10

  @ZoeInMyDna-codePosted 4 months ago

  @DylandeBruijn

  You really took out time to access the code and the design and brought out constructive feed backs for me.

  I would do well to take note of the correctioms and see if I can rewrite some of the codes.

  What do you suggest I do when I need a tag and I don't know the name where can I find what to do

  0

  

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @ZoeInMyDna-code

  MDN is a great resource! They have great guides aswell.

  0
• 

  Moamen Abdelrahman•340

  @MoamenAbdelrahman7Posted 4 months ago

  paragraph font size should be smaller

  0

  ---

  

  ZoeInMyDna-code•10

  @ZoeInMyDna-codePosted 4 months ago

  @MoamenAbdelrahman7

  About how many px I would like to heed the correction

  0

  

  ZoeInMyDna-code•10

  @ZoeInMyDna-codePosted 4 months ago

  @MoamenAbdelrahman7

  About how many px I would like to heed the correction

  0

  

  Moamen Abdelrahman•340

  @MoamenAbdelrahman7Posted 4 months ago

  @ZoeInMyDna-code make it about 12px or 13px

  0
• 

  bassdesigns•10

  @bassdesignsPosted 4 months ago

  Kudos for not giving up, well done and continue to improve

  0

  ---

  

  ZoeInMyDna-code•10

  @ZoeInMyDna-codePosted 4 months ago

  Thank youuuuu@bassdesigns

  0