vs code

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Nice job in completing this challenge. Regarding your solution, I would like to take notes of the following…

  • Remove this line in the code...

    Improve your front-end skills by building projects
  
    Scan the QR code to visit Frontend Mentor and take your coding skills to the next level
  

  • Instead of div, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. This line <div class="all"> can be wrap with main tag
  • Add the inline style which is bgcolor="#D5E1EF" in the CSS file on body ruleset
  • Remove margin: 250px;, margin-top: 60px;, position: relative; and display: inline-block; in the .all ruleset and add display: flex;, justify-content: center;, align-items: center; and margin: 7rem auto;
  • Remove border-left: 14px solid transparent; and border-right: 17px solid transparent; in the .txt1 ruleset and add padding: 0 1rem;
  • Remove border-left: 22px solid transparent; and border-right: 13px solid transparent; in the .txt2 ruleset and add padding: 0 1.5rem;

  In the brighter side...

  • The project is responsive and utilized the details based on the original design
  • Good job in using a separate file for the CSS in styling, the composition is done well

  Above all, the project is done well. Keep up the good work! Cheers!

  0

  ---

  

  hend•260

  @hendsaeeddPosted over 2 years ago

  @RioCantre thanks

  0
• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  Hi, Remove the HTML which you did not use. Also center the content w.r.t screen. You can do it by using below code:

  body{
    display:flex;
    align-itmes:center;
    justify-content: center;
    min-height:100vh
  }
  

  Rest look okay.

  Good Luck, #happyCoding

  0

  ---

  

  hend•260

  @hendsaeeddPosted over 2 years ago

  @besttlookk thank you

  0