Design comparison
Community feedback
- @FarisPalayiPosted over 3 years ago
To do that, instead of giving the
background-position
fixed values like em or px try to give it relative values like vw, vh or %ges. If you want to, you can take a look at my solution or any other people's solutions in order to understand how other people have done it. And nice solution btw👍. As always, happy coding ✨Marked as helpful1@DrZubbyPosted over 3 years ago@FarisPalayi
Done! and it worked. I initially thought that em was also a relative value. Please are you good with JS? I could use some mentorship from you. My progress with JS has not been up to speed.
1@FarisPalayiPosted over 3 years ago@DrZubby yeah, that was a mistake,
em
is a relative value. What I meant here was relative to viewport/container's size. Even thoughem
is relative, you need to change the element's or element's parent's value, in order to change the value.I believe my JS skills are pretty solid. But, what do you mean when you say mentorship?
And also, as a side note, JS can be a bit hard to follow if you are new to programming because unlike html and css you need to start to think like a programmer.
0@DrZubbyPosted over 3 years ago@FarisPalayi
When I say mentorship, I mean putting me through on areas that I find difficult anytime I request for such. Also advice on the best approaches to solving certain problems or learning certain concepts (As you did with this feedback and the last one too.).
Your github repo is impressive and I figured out that it would not be a bad idea to request for guidance.
Thanks.
1@FarisPalayiPosted over 3 years ago@DrZubby Thanks! I think I could do that😃. But, as a word of warning, don't expect a lot from me, I'm also someone whose actively learning. So, you are in slack right?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord