Vs code, HTML, CSS and Flexbox

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi Rebecca,

  I think you'll want to take another look at this for mobile (I'll add a screenshot to slack for you)

  There are issues because

  • height instead of min-height on the container
  • width in vw units on the card. Instead try a max width in pixels. Although 25vw probably looked great on your computer screen, it won't suit everyones screens, and definitely wo t for mobiles.
  • height on the card - do you even need a height on it? I usually let things take up whatever height they need without specifying
  • position absolute on the card (I think I saw it had that but can't remember for sure). If you're positioning with flexbox anyway you shouldn't need to absolutely position it

  Really nice structure to your html though and desktop preview looks good! ☺

  1