@denielden
Posted
Hello Juwon, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - not use void
p
tag to make space but usemargin
property - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of text - remove all
margin
fromcontainer
class and body - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px or %
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@CodeGod36
Posted
@denielden Hi, i tried aligning the card using flexbox but i wasn't able to do so. Can you give more tips in how i can do so please. Thank You.
@denielden
Posted
@CodeGod36 You are welcome and keep it up :)
It's very simple in the link of my comment there is a very detailed and complete guide... anyway put these properties in the body:
display: flex;
align-items: center;
justify-content: center;
min-height: 100vh;