Vite, tailwindcss

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Furkan, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the main content of page for improve the Accessibility
  • use article tag instead of a simple div to the container card of countries for improve the Accessibility
  • add descriptive text in the alt attribute of the images not flag for all
  • add transition on the html to smooth the change theme color
  • inside ul element use only li not h4.. fix it like this: <li> <h4>NameCountry</h4> </li>
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Furkan Kayış•150

  @furkan-kayisPosted almost 2 years ago

  @denielden thanks for the tips sir, i'm trying to implement all of them!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @furkan-kayis You are welcome and keep it up :)

  Marked as helpful

  1