@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div class="caja">
with semantic element<main>
to improve accessibility and organization of your page.
CSS 🎨:
- We don't want
margin
to center the component both horizontally & vertically, instead remove themargin: 10rem auto;
for.caja
in css
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📙.
- For this demonstration we use css
grid
to center the component
body {
min-height: 100vh;
display: grid;
place-items: center;
margin: 0;
}
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful