QR-code Scanner Challenge

Community feedback

• 

  Maximilian Dybvik•200

  @RegexRiddlerPosted 7 months ago

  Well done! I like your use of Flexbox to center the card vertically and horizontally.

  There are however a few small things I would like to point out:

  1. You have forgotten to limit the card width to 320px on larger screens. A simple max-width: 320px; on your card class would do it.
  2. Since the size of the card is the same on both small and large screens there is no need for the @media(width: 375px) breakpoint. Again just limit the size of the card.
  3. The first div with a class of attribution inside the body element is redundant and you could remove it and move all of its CSS styles to the body element instead.

  Marked as helpful

  1

  ---

  

  shiwanikandpal•50

  @shiwanikandpalPosted 7 months ago

  @RegexRiddler Thank you for your feedback! I appreciate your positive remarks and the constructive suggestions. I'll make sure to implement the changes you've mentioned to improve the responsiveness and efficiency of the code. Your insights are valuable to me, and I'm grateful for them.

  0