Skip to content
Submitted about 2 years ago

Visual Code, HTML,CSS

#webpack
agustinburne•10
@agustinburne
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi! I'm a beginner in this. Feedback welcome :)

Community feedback

  • Lucas 👾•104,300
    @correlucasPosted about 2 years ago

    👾Hi @agustinburne, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    The HTML structure is fine and works, and you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
  • Hugo Méndez•180
    @HugomndezPosted about 2 years ago

    Hi @agustinburne, Your solution looks fantastic!!

    I did catch some bugs on your css you have

    h2{
    color: hsl(218, 44%, 22%);
    font-weight: 700;
    font-size: 2rem;
}

    and I think it should be:

    h1{
    color: hsl(218, 44%, 22%);
    font-weight: 700;
    font-size: 2rem;
}

    on my solution I use "px" instead of "%" for "border-radius".

    Marked as helpful
    0
  • Abdullah Ayoola•1,080
    @abdullah43577Posted about 2 years ago

    That's nice

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord