Skip to content
Submitted over 3 years ago

Victor - Profile card

Nicolas Aguilera García•20
@niaggar
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi!

This is my first challenge, I don't know if its the best solution but i tried (I think that the CSS file could be smaller). So I read the comments if anyone has something to tell me 😊

And thanks in advance!

Community feedback

  • Eric Karugu•210
    @erickaruguPosted over 3 years ago

    Hello Nicolas👋

    Welcome to Frontend Mentor!🙌 For your first challenge, you have done an amazing job. Regarding the CSS being smaller that is true but personally I prefer having a working solution and then refactor from there instead of struggling to look for the shortest way from the word go.

    A brief suggestion, while you are doing that maybe you can fix the images issue by adding the alt text. It is really helpful when it comes to screen readers. Also, you can look at BEM classes naming convention to have your classes consistent and easier to follow.

    Happy coding!👩‍💻

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord