Very novice. Didn't use Figma. Probably wrote a lot of dumb stuff.

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 5 months ago

  Hiya @DarkCityTreno,

  Congratulations on a great looking solution. Writing stuff is definitely not the same as watching courses. But that's probably why you are here on Frontend Mentor, to get out of tutorial hell. I like that you used display: grid and place-content: center to center the card. It's a very clean solution.

  A bit of friendly constructive feedback:

  • I'm happy to see you used min-height: 100vh on the body. A lot of people make the mistake to use height: 100vh.

  • I like that you used cascading by putting text-align: center on the main.

  • You can make the card a bit more responsive by changing your styling to this:

  main {
      max-width: 450px;
      width: 100%;
      padding: 5%;
      background-color: hsl(0, 0%, 100%);
      border-radius: 15px;
      text-align: center;
  }
  

  If you want the same padding on all the sides you don't have to write padding: 5% 5% you can shorten it to padding: 5%.

  • I suggest looking into CSS variables, they help you make your CSS values more reusable across your code.

  • You could add a bit of padding to your body to give your card a bit of spacing between itself and the edges of the viewport.

  Again good job on your solution and I hope you find my feedback helpful. If you do I would appreciate it if you can mark it as helpful!

  Happy coding!

  Marked as helpful

  1

  ---

  

  DarkCityTreno•80

  @DarkCityTrenoPosted 5 months ago

  Hey @DylandeBruijn Thank you so much for your feedback. You're absolutely right about padding, just really hard to remember stuff cuz it's a lot take in for a beginner. Will defenitely look into CSS variables. Really appreciate the criticism bro cheers!

  0

  

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 5 months ago

  Hiya @DarkCityTreno,

  No worries at all! I understand all too well how hard it is to remember stuff. And it's hard to keep track of things sometimes as your project grows. I'm glad I could help you out! If you have any more questions I would be happy to answer them.

  1
• 

  steve-brodsky•10

  @steve-brodskyPosted 5 months ago

  Great job!

  2