Vanilla JS with SASS

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @roman02021 ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • Please try BEM for naming element classes. It will help you a lot on bigger projects.
  • Image tags must have alt attributes as standard.
  • I think explore button hover effect doesn't match design.
  • Please try dark background-color for pages, so that when moving between pages, it won't blink.

  https://www.frontendmentor.io/challenges/space-tourism-multipage-website-gRWj1URZ3/hub/space-tourism-multipage-solution-LCqAfReWO

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  0
• 

  Nat•200

  @NatGlassPosted almost 3 years ago

  I'd recommend setting a max-width to the header container, you've got the right idea but I think it'd be easier to only show it when the screen is above a set width. This will also make the header look better on very large screens, as the logo floats off and the nav background extends infinitely while the page content is centered which looks odd.

  Overall you did a great job.

  Marked as helpful

  0