Design comparison
Solution retrospective
Latest project. Please provide some code review if possible :)
Thanks Guys
Community feedback
- @DavidMorgadePosted over 2 years ago
Hey man!, Your JS file looks really clean just a few things I would change that maybe you didnt notice during development.
Maybe it would be better if your item-count reset to 0 on screen when you add something to the shopping cart like Amazon and those kind of websites do.
Other thing I noticed is that if you add 0 to the cart, the cart restarts again with no items even if I have already items in the cart. Look at that maybe you can get a guard close when clicking the add to cart button when its 0.
But as I said your code looks so clean and I like it!, nice work.
Marked as helpful1@NicoPomPosted over 2 years ago@DavidMorgade Thank you for very much man ! I honestly thought my file was not that clean. So thank you for your encouraging comment.
I fixed the two things you noticed. Could you please check if it now looks the way you intended ?
Thanks again
0@DavidMorgadePosted over 2 years ago@NicoPom Yes your fixes seems to work properly, very good job man.
And yes, for me, your JS looks clean, I'm gonna take some references from your code for my future proyects!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord