@JohnBroers
Posted
Really nice job on your solution. Looking spot on with the design. Your sass and javascript is looking well structured. Nice job on using mixins for breakpoints and using css variables.
A couple things that i noticed in your javascript:
- I don't think you need to declare lat and lng variable in the global scope. You only set it once in the function, and pass is on to other functions as arguments. No need to declare it global i think.
- I see one 'var' variable which you might wanna change into a const.
Another thing i noticed here in the accessibility report is that the submit button is missing a text label for screen readers. You might wanna add a screenreader only text element or add an aria-label to fix that issue.
I agree with you that it was a fun challenge to work on, had a great time working on it as well.
Marked as helpful
@bibmode
Posted
@JohnBroers this is a really, really helpful comment. Thanks! I'll def work on these suggestions tomorrow. :D