Vanilla JS ecommerce-product-landing-page

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey Manik2375, good job completing this challenge. Keep up the good work

  Your solution looks great however I think that the titles and description are supposed to be a bit bigger in addition to the overall content.

  In terms of the validation errors

  • Attribute area-hidden not allowed on element svg at this point.

  • Possible misuse of aria-label, you don't need the aria-label on a heading element

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  1

  ---

  

  Manik Kapoor•370

  @Manik2375Posted over 2 years ago

  @TheCoderGuru Thanks for suggestions!

  Oh, I will make them a bit larger then, used to small fonts :sweat_smile:

  And I am not really sure about validation errors,

  • I believe the validator is thinking svg as an important element here (perhaps like with some text content), but its just for decoration purpose, for example this article https://web.dev/learn/design/icons/

  • Yeah, I think that is little weird because aria-label is more like for accessible interactive things, from my POV. But when reading from screenreaders, it is useful. Perhaps I should use title here, to avoid ruining the design.

  Once again, really thanks for reviewing it! I really appreciate this!

  0