Vanilla JS / CSS

Community feedback

• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey @klyvoon, Congratulations on completing this challenge!

  Here is my feedback:

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  Keep doing a good job!

  0

  ---

  

  klyvoon•110

  @klyvoonPosted about 2 years ago

  @Deolabest Thanks for the feedback, I think I should have put the font-size directly on the body element. For the main, indeed, I should have interchange the first div with the main tag. Have a nice day !

  0