Design comparison
Solution retrospective
Some SVGs were not aligned correctly (intended?), had to use relative/absolute positioning here. Is it ok to do so?
Community feedback
- @hassanahmadpPosted almost 4 years ago
Great work is done Janne!
As you asked about using positioning, it is perfectly fine to use it. However, I found some issues with the mobile view as the main SVG part does not show properly, for that I suggest using fixed height in this case (although I discourage using fixed heights)... also there is one minor issue too that is there is no
altattribute for the image used... you need to work on the drop-down transition too...Other than that you have done a great job...
2 - @ApplePieGiraffePosted almost 4 years ago
Hey, nice work on this challenge, Janne Nissinen! 👍
Your solution looks good and the accordion card works very well! 👏
As hassanahmadp mentioned, using relative or absolute positioning in this challenge is totally fine and I think you've placed the SVGs quite well.
I only suggest adding a
max-widthto the accordion card to prevent it from becoming too wide on extra-large screens. 😉Keep coding (and happy coding, too)! 😁
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord