Design comparison
Solution retrospective
I`m open to any feedback.
Community feedback
- Account deleted
Hi,
Nice one on the challenge, it looks good but there seems to quite a lot of short comings with the styling, a lot of things seems like they were rushed.
- The styling needs a little bit more work, the calculator just looks unfinished.
- On the other side the functionality seems to be pretty good, but you must restrict the inputs to only accept numbers, because currently I can enter the whole keyboard in there.
Other than that, I think it's ok.
Keep coding👍.
2@SbZhechevPosted about 3 years ago@thulanigamtee Now that you mentioned the styling is unfinished I saw some details not exactly matching the design.
As for the restrictions, I am validating the input when calculating. You can enter some text but it will not trigger calculation if any of the inputs receive text. I guess I could add validation like the one for number of people on all the inputs.
Thanks for the feedback!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord